From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 10D6F3857C56 for ; Wed, 21 Apr 2021 05:41:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 10D6F3857C56 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-2HadNEnHMrWoea-AdMi8Dg-1; Wed, 21 Apr 2021 01:41:09 -0400 X-MC-Unique: 2HadNEnHMrWoea-AdMi8Dg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2BB0189DF51; Wed, 21 Apr 2021 05:40:53 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-20.ams2.redhat.com [10.36.113.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE08F5D9D0; Wed, 21 Apr 2021 05:40:51 +0000 (UTC) From: Florian Weimer To: "Alejandro Colomar (man-pages)" Cc: "Michael Kerrisk (man-pages) via Libc-alpha" , Jakub Wilk , "Michael Kerrisk (man-pages)" , linux-man@vger.kernel.org Subject: Re: [PATCH v5 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-1-alx.manpages@gmail.com> <4298cc3c-8f24-5a3c-3c54-b24ca804d373@gmail.com> <87y2doni1m.fsf@oldenburg.str.redhat.com> <365dc717-eb20-4549-9b6a-09eeadcfc89d@gmail.com> Date: Wed, 21 Apr 2021 07:41:07 +0200 In-Reply-To: <365dc717-eb20-4549-9b6a-09eeadcfc89d@gmail.com> (Alejandro Colomar's message of "Mon, 12 Apr 2021 11:09:24 +0200") Message-ID: <87pmyoqjnw.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 05:41:17 -0000 * Alejandro Colomar: >> Or, more succinctly, put the types in comments: >> >> syscall(SYS_arch_prctl, /* int */ code, /* unsigned long */ addr); > > I'm not sure. I see the point in doing this, but I think I prefer my > version, because it has less noise. But I might be a bit biased :) Not everyone is deeply familiar with C syntax. Anyone who uses the example literally will be disappointed. Thanks, Florian