From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] x86: Add CPU-specific diagnostics to ld.so --list-diagnostics
Date: Tue, 02 Mar 2021 07:32:39 +0100 [thread overview]
Message-ID: <87pn0i2hh4.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOqHWYiBgzs7pj5e0XNCEnd3-m7VvpPSk8ofxj65omfeDg@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Mon, 1 Mar 2021 15:20:19 -0800")
* H. J. Lu via Libc-alpha:
>> + for (unsigned int index = 0; index < CPUID_INDEX_MAX; ++index)
>> + {
>> + /* The index values are part of the ABI via
>> + <sys/platform/x86.h>, so translating them to strings is not
>> + necessary. */
>> + for (unsigned int reg = 0; reg < 4; ++reg)
>> + print_cpu_feature_internal
>> + (index, "cpuid", reg,
>> + cpu_features->features[index].cpuid_array[reg]);
>> + for (unsigned int reg = 0; reg < 4; ++reg)
>> + print_cpu_feature_internal
>> + (index, "usable", reg,
>> + cpu_features->features[index].usable_array[reg]);
>> + }
>
> No changes when new CPUID leaves are added.
Sorry, what do you mean by that?
> These should be auto-define/generated from sysdeps/x86/include/cpu-features.h.
> Can they be auto-define/generated from sysdeps/x86/include/cpu-features.h?
I don't think we have good tool support for that at present. I can add
comments to cpu-features.h referencing the diagnostics functionality.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-02 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 13:42 [PATCH 1/2] ld.so: Implement the --list-diagnostics option Florian Weimer
2021-02-24 13:43 ` [PATCH 2/2] x86: Add CPU-specific diagnostics to ld.so --list-diagnostics Florian Weimer
2021-03-01 23:20 ` H.J. Lu
2021-03-02 6:32 ` Florian Weimer [this message]
2021-03-01 9:12 ` [PATCH 1/2] ld.so: Implement the --list-diagnostics option Florian Weimer
2021-03-01 23:13 ` H.J. Lu
2021-03-02 6:00 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn0i2hh4.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).