public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Carlos O'Donell <carlos@redhat.com>,
	 GNU C Library <libc-alpha@sourceware.org>,
	 "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] Fix tst-setcontext9 for optimized small stacks.
Date: Thu, 27 Sep 2018 10:06:00 -0000	[thread overview]
Message-ID: <87pnwztfti.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvm5zyr8fm6.fsf@suse.de> (Andreas Schwab's message of "Thu, 27 Sep 2018 11:16:33 +0200")

* Andreas Schwab:

> On Sep 26 2018, Carlos O'Donell <carlos@redhat.com> wrote:
>
>> Does it run out of stack?
>
> Definitely.
>
> Andreas.
>
> 	[BZ #23717]
> 	* stdlib/tst-setcontext9.c (f1a): Make st2 static.
> 	(do_test): Make st1 static.

I'm happy to report that this fixes powerpc64le for me.  The change
looks reasonable.  Maybe you coulkd mention somewhere (in the ChangeLog
entry or the commit message) that this is to reduce stack usage and
avoid stack overflows.

Thanks,
Florian

  reply	other threads:[~2018-09-27 10:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 14:31 Carlos O'Donell
2018-09-18 14:56 ` H.J. Lu
2018-09-26 22:26 ` Florian Weimer
2018-09-27  0:10   ` Carlos O'Donell
2018-09-27  4:57     ` Florian Weimer
2018-09-27  9:16     ` Andreas Schwab
2018-09-27 10:06       ` Florian Weimer [this message]
2018-09-27 18:26       ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnwztfti.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).