From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124540 invoked by alias); 21 Oct 2016 21:15:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 124483 invoked by uid 89); 21 Oct 2016 21:15:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,URIBL_RED autolearn=no version=3.3.2 spammy=ffs X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Joseph Myers , libc-alpha@sourceware.org Cc: Subject: Re: Use -fno-builtin for sqrt benchmark In-Reply-To: References: User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Fri, 21 Oct 2016 21:15:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102121-0028-0000-0000-0000015BC517 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102121-0029-0000-0000-0000144ED459 Message-Id: <87pomtjtf8.fsf@totoro.br.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-21_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610210377 X-SW-Source: 2016-10/txt/msg00369.txt.bz2 Joseph Myers writes: > This patch makes the sqrt benchmark use -fno-builtin, as already done > for benchmarks of ffs and ffsll, so that it actually benchmarks the > glibc function as (presumably) intended even in the presence of the > compiler inlining sqrt. > > Tested for x86_64 and also used for benchmarking my ARM sqrt patch. > > 2016-10-21 Joseph Myers > > * benchtests/Makefile (CFLAGS-bench-sqrt.c): New variable. > > diff --git a/benchtests/Makefile b/benchtests/Makefile > index 144b32e..5a61522 100644 > --- a/benchtests/Makefile > +++ b/benchtests/Makefile > @@ -72,6 +72,7 @@ benchset := $(string-benchset-all) $(stdlib-benchset) $(stdio-common-benchset) \ > > CFLAGS-bench-ffs.c += -fno-builtin > CFLAGS-bench-ffsll.c += -fno-builtin > +CFLAGS-bench-sqrt.c += -fno-builtin > > bench-malloc := malloc-thread LGTM. -- Tulio Magno