* [PATCH] libio: Correctly link tst-popen-fork against libpthread
@ 2024-10-25 2:32 Arjun Shankar
2024-10-25 4:51 ` Florian Weimer
0 siblings, 1 reply; 2+ messages in thread
From: Arjun Shankar @ 2024-10-25 2:32 UTC (permalink / raw)
To: libc-alpha; +Cc: Joseph Myers, Florian Weimer
tst-popen-fork failed to build for Hurd due to not being linked with
libpthread. This commit fixes that.
Tested with build-many-glibcs.py for i686-gnu.
---
Joseph reported the build failure here:
https://sourceware.org/pipermail/libc-alpha/2024-October/160857.html
libio/Makefile | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libio/Makefile b/libio/Makefile
index 018c26d971..8cc8be7776 100644
--- a/libio/Makefile
+++ b/libio/Makefile
@@ -119,7 +119,6 @@ tests = \
tst-mmap-offend \
tst-mmap-setvbuf \
tst-mmap2-eofsync \
- tst-popen-fork \
tst-popen1 \
tst-setvbuf1 \
tst-sprintf-chk-ub \
@@ -144,6 +143,14 @@ tests = \
tst_wscanf \
# tests
+ifeq ($(have-thread-library),yes)
+tests += \
+ tst-popen-fork \
+ # tests
+endif
+
+$(objpfx)tst-popen-fork: $(shared-thread-library)
+
tests-internal = tst-vtables tst-vtables-interposed
ifeq (yes,$(build-shared))
--
2.46.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libio: Correctly link tst-popen-fork against libpthread
2024-10-25 2:32 [PATCH] libio: Correctly link tst-popen-fork against libpthread Arjun Shankar
@ 2024-10-25 4:51 ` Florian Weimer
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2024-10-25 4:51 UTC (permalink / raw)
To: Arjun Shankar; +Cc: libc-alpha, Joseph Myers
* Arjun Shankar:
> tst-popen-fork failed to build for Hurd due to not being linked with
> libpthread. This commit fixes that.
>
> Tested with build-many-glibcs.py for i686-gnu.
> ---
> Joseph reported the build failure here:
> https://sourceware.org/pipermail/libc-alpha/2024-October/160857.html
>
> libio/Makefile | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/libio/Makefile b/libio/Makefile
> index 018c26d971..8cc8be7776 100644
> --- a/libio/Makefile
> +++ b/libio/Makefile
> @@ -119,7 +119,6 @@ tests = \
> tst-mmap-offend \
> tst-mmap-setvbuf \
> tst-mmap2-eofsync \
> - tst-popen-fork \
> tst-popen1 \
> tst-setvbuf1 \
> tst-sprintf-chk-ub \
> @@ -144,6 +143,14 @@ tests = \
> tst_wscanf \
> # tests
>
> +ifeq ($(have-thread-library),yes)
> +tests += \
> + tst-popen-fork \
> + # tests
> +endif
> +
> +$(objpfx)tst-popen-fork: $(shared-thread-library)
> +
> tests-internal = tst-vtables tst-vtables-interposed
>
> ifeq (yes,$(build-shared))
I think you can assume that $(hve-thread-library) is always yes, so that
additional condition isn't required. Just add the dependency.
Thanks,
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-25 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-25 2:32 [PATCH] libio: Correctly link tst-popen-fork against libpthread Arjun Shankar
2024-10-25 4:51 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).