From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5F3383858D39 for ; Thu, 16 Nov 2023 19:16:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F3383858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F3383858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700162169; cv=none; b=oNCEtKPcASpBYl1RM1NGbBG0tgxVkj8l26S1R0GsanvUivPHRR2usvZUWCf8P9JawN2LVVCf+Kmk9RGokRWUaXB+ghpxoZPUJFR0Csu84bh/k/D3NRNFe50mHGYM/jzZ6E86f2cHGYFfmVz+yvLvy5wBkEjS44hrz6jUC8G/YEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700162169; c=relaxed/simple; bh=pJqUWv/RTxyaEd9ClFqBATXK2cdoqhfN8zlEj3EXnYs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UafzBB6N7EGXWqmnf0wwzFCNbohnf6iy8WQNMuakfXNou5WLKKBI0GYbEp/DGBlbBHSRe0NQDYHJNWNt8W+BZ5nAO5AQey2Zy6aXv+rSTR+dzCXTcRKh70VYg6ZOJLXySkKhuBjQ3dRsjsdh/2w0Lwl2Tqy+C7eOFsNnytrPoew= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700162167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6/oYj91kRCtDm8DIiFk+SSY9CXwqKWPArjLyprpHtX8=; b=XX5qtc3AY/UYK55bquAJ3MRxcSmO/l0TBcTCfh6tMfhh67Ek53U/ydoYDPTNanEd+VnkWX eyeDOXWZG3M5ghZQTaiCKYv9dsajVV00ZdKWxObRszLBMKI5iT9zDPVk7iPqMkDzZQi6Xm UBMwTraT3LiHTio8Zc3ZiQL7UD0W7+o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-6mmopVgpNfOp9m0oaevRuA-1; Thu, 16 Nov 2023 14:16:03 -0500 X-MC-Unique: 6mmopVgpNfOp9m0oaevRuA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 466E9830965; Thu, 16 Nov 2023 19:16:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B84981C060AE; Thu, 16 Nov 2023 19:16:02 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2] elf: Fix force_first handling in dlclose (bug 30785) References: <87edh1bl0r.fsf@oldenburg.str.redhat.com> Date: Thu, 16 Nov 2023 20:16:01 +0100 In-Reply-To: (Adhemerval Zanella Netto's message of "Thu, 16 Nov 2023 15:32:11 -0300") Message-ID: <87r0kpqzke.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 07/11/23 13:12, Florian Weimer wrote: >> The force_first parameter was ineffective because the dlclose'd >> object was not necessarily the first in the maps array. Also >> enable force_first handling unconditionally, regardless of namespace. >> The initial object in a namespace should be destructed first, too. >> >> The _dl_sort_maps_dfs function had early returns for relocation >> dependency processing which broke force_first handling, too, and >> this is fixed in this change as well. > > Would you re-open 30785 or this patch is intended for 30981? Good point, I should reference bug 30981 instead. > Also, as a side note, it is really not helpful to link a RH bug report > [1] that is not easily accessible (it requires to log with a RH > account and ask for extra permission). > [1] https://bugzilla.redhat.com/show_bug.cgi?id=2233338 I think at the time, I still had hope that it could be made public, but that didn't happen. The bug doesn't even list our many failed attempts at fixing it, most of these problems occurred in Fedora. > I think to link external trackers, it must not require additional steps > to query for the report information; otherwise I see no point in keeping > such links on the sourceware bugzilla. > > The patch itself looks good, thanks. > > Reviewed-by: Adhemerval Zanella Thanks, I'll push it after updating the bug reference. Thanks, Florian