public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] time: Set daylight to 1 for matching DST/offset change (bug 29951)
Date: Mon, 02 Jan 2023 12:56:09 +0100	[thread overview]
Message-ID: <87r0wdp2ue.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87ilhpp3d0.fsf@igel.home> (Andreas Schwab's message of "Mon, 02 Jan 2023 12:44:59 +0100")

* Andreas Schwab:

> On Jan 02 2023, Florian Weimer via Libc-alpha wrote:
>
>> +      /* Keep searching to seet if there is a DST rule.  This
>
> s/seet/see/
>
>> +  /* Check that localtime re-initializes the two variables.  */
>> +  daylight = timezone = 17;
>> +  time_t t = 844034401;
>> +  struct tm *tm = localtime (&t);
>> +  TEST_COMPARE (daylight, 1);
>
> The manual documents only a non-zero value.
>
>> +  TEST_COMPARE (daylight, 1);
>> +  TEST_COMPARE (timezone, -7200);
>
> Duplicate tests.

Thanks, I'm going to send a fixed version.

Florian


      reply	other threads:[~2023-01-02 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 11:18 Florian Weimer
2023-01-02 11:44 ` Andreas Schwab
2023-01-02 11:56   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0wdp2ue.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).