From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 77389391C358 for ; Thu, 8 Dec 2022 18:10:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77389391C358 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670523033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5M+7P3YTctr/tZuj+TiG06CI/Q8zCKZYacOE7o47QDs=; b=HJMqL6Nw2wyJbsYGjOQbdFEdzkc/XodMXvqH+ssWx5rhU+8AuDJENoPXhuxRzQ1v5c3KfG ZcbROcTcCGcx5A5nHijpZYrTyksmgadIajhrGpIPJWaGxYGUgHTG7vL26rOKprwvJVCd9c cJ6Q1ZQCMt4CLgBHMEELlFzKbTwkK/g= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-7ABVc5mhO663LRxrk9hesQ-1; Thu, 08 Dec 2022 13:10:28 -0500 X-MC-Unique: 7ABVc5mhO663LRxrk9hesQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E2FC33C0F242; Thu, 8 Dec 2022 18:10:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3930040C6EC2; Thu, 8 Dec 2022 18:10:27 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] : Make bsd_signal available with _GNU_SOURCE References: <8735a3tlg9.fsf@oldenburg.str.redhat.com> Date: Thu, 08 Dec 2022 19:10:23 +0100 In-Reply-To: (Adhemerval Zanella Netto's message of "Thu, 8 Dec 2022 14:11:19 -0300") Message-ID: <87r0x9hils.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 28/11/22 07:36, Florian Weimer via Libc-alpha wrote: >> The declaration does not conflict with anything. This simplifies >> porting older software to C99 compilers which do not support implicit >> function declarations and which need -D_GNU_SOURCE for other function >> declarations. Using __USE_MISC does not seem appropriate here because >> other systems (e.g., FreeBSD) do not declare bsd_signal. > > I am not sure about this, bsd_signal is a POSIX deprecated and I think > old software should really move to sigaction or define the correct flags > to explicit use it. And I thought this was the least controversial patch. 8-/ If -D_GNU_SOURCE is not the superset of all functionalities, it gets more difficult to obtain all function prototypes, as needed for building with stricter C99 compilers. Currently, with default GCC flags, this builds anyway due to an implicit function declaration, and I'd like to preserve this behavior with GCC 14. What about adding a deprecation warning? Thanks, Florian