From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 54D7D3858D37 for ; Thu, 3 Nov 2022 11:29:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54D7D3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667474948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=If7rQA9NWcDvsYH6oESz1GMwQd9mNjo3T6S6X4rnJEs=; b=BtkaWpr6ygkxW7rrbYyufDk5bms6CN/FBrBSK6y4ODaLPDnoJ12jZh2cG5/Oo4DfSuVvDt IuF+JW3oCQpuzgdgN3I42jqc9eOkjxGZQuJQst9tuFodredjoR0HGNP714tEJ8NsxLxeax ZsSmme7Q7jzI0AN2heek2bYeZryARQY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-ouh7G1xAPMeWXKm4N7w53Q-1; Thu, 03 Nov 2022 07:29:07 -0400 X-MC-Unique: ouh7G1xAPMeWXKm4N7w53Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 01B811C0A104 for ; Thu, 3 Nov 2022 11:29:07 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 681611415123 for ; Thu, 3 Nov 2022 11:29:06 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH COMMITTED] scripts/glibcelf.py: Properly report parsing failures Date: Thu, 03 Nov 2022 12:29:05 +0100 Message-ID: <87r0ykff9a.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Without this change, parse failures result in an exception: Traceback (most recent call last): File "tst-glibcelf.py", line 23, in import glibcelf File "/path/to/git/scripts/glibcelf.py", line 226, in _elf_h = _parse_elf_h() File "/path/to/git/scripts/glibcelf.py", line 221, in _parse_elf_h result = glibcpp.macro_eval(glibcpp.macro_definitions(tokens), reporter) File "/path/to/git/scripts/glibcpp.py", line 379, in macro_eval reporter.error(md.line, 'macro {} redefined'.format(md.name)) File "/path/to/git/scripts/glibcelf.py", line 214, in error errors += 1 UnboundLocalError: local variable 'errors' referenced before assignment --- scripts/glibcelf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py index 420cb21943..59aab56ecf 100644 --- a/scripts/glibcelf.py +++ b/scripts/glibcelf.py @@ -211,7 +211,7 @@ def _parse_elf_h(): self.errors = 0 def error(self, line, message): - errors += 1 + self.errors += 1 print('{}:{}: error: {}'.format(path, line, message)) def note(self, line, message): base-commit: ee1ada1bdb8074de6e1bdc956ab19aef7b6a7872