From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EE95F3856DC8 for ; Thu, 14 Apr 2022 15:28:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE95F3856DC8 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-14-WAJg16yBPBGCqEaIr8L8Dg-1; Thu, 14 Apr 2022 11:28:08 -0400 X-MC-Unique: WAJg16yBPBGCqEaIr8L8Dg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2596A1014A63; Thu, 14 Apr 2022 15:28:08 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A3E3111D3CB; Thu, 14 Apr 2022 15:28:07 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 0/4] Move libio lock single-thread optimization to generic libc-lock References: <20210527204457.1250196-1-adhemerval.zanella@linaro.org> <87sfqifqat.fsf@oldenburg.str.redhat.com> <717d3eec-dbc0-d9e6-185f-a02541591c6c@linaro.org> Date: Thu, 14 Apr 2022 17:28:05 +0200 In-Reply-To: <717d3eec-dbc0-d9e6-185f-a02541591c6c@linaro.org> (Adhemerval Zanella's message of "Thu, 14 Apr 2022 11:23:08 -0300") Message-ID: <87r15zwupm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 15:28:12 -0000 * Adhemerval Zanella: > On 12/04/2022 09:18, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> This patchset removes some old unused code (_IO_lock_inexpensive >>> and _IO_MTSAFE_IO), consolidate the stdio-lock.h and move the >>> single-thread lock optimization to generic code instead of >>> per-function usage. >>> >>> Adhemerval Zanella (4): >>> libio: Assume _IO_lock_inexpensive >>> libio: Assume _IO_MTSAFE_IO >>> Consolidate stdio-lock.h >>> Move libio lock single-thread optimization to generic libc-lock (BZ >>> #27842) >> >> This series is still assigned to me in Patchwork. Is it still active? > > I think it would be a good micro-optimization and a code consolidation, > although I am not sure if it still applies. If you think it would be > a good addition I can work on rebase and send a new version. I'm interested in the _IO_MTSAFE_IO consolidation, but the rest looks useful as well. I think we have some places where we define stdio locking macros differently for no apparent reason, that that's just waiting to cause trouble. Thanks, Florian