From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 6580E3858C53 for ; Wed, 13 Apr 2022 12:46:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6580E3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Kdj5T2s6bz1s94G; Wed, 13 Apr 2022 14:46:37 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Kdj5T1SSJz1qqkC; Wed, 13 Apr 2022 14:46:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id HOarn711FBde; Wed, 13 Apr 2022 14:46:36 +0200 (CEST) X-Auth-Info: 2YK7BLNVi6y2Z1KsH8lUXKcWLcWc4HRn1GWHfbfcSsAyPyYT7pN0pzS5gpG/xb3C Received: from igel.home (ppp-46-244-173-163.dynamic.mnet-online.de [46.244.173.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 13 Apr 2022 14:46:36 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id F40E72C371F; Wed, 13 Apr 2022 14:46:35 +0200 (CEST) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Yang Yanchao , Florian Weimer , linfeilong@huawei.com Subject: Re: [PATCH v4] elf: fixes compile error when both enable -Werror and -DNDEBUG References: <20220412094741.1902-1-yangyanchao6@huawei.com> <87tuax47bg.fsf@oldenburg.str.redhat.com> X-Yow: - if it GLISTENS, gobble it!! Date: Wed, 13 Apr 2022 14:46:35 +0200 In-Reply-To: <87tuax47bg.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 13 Apr 2022 12:16:19 +0200") Message-ID: <87r16140d0.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 12:46:40 -0000 On Apr 13 2022, Florian Weimer via Libc-alpha wrote: > Personally I would prefer __attribute__ ((unused)) directly on the > old_offset declaration. I think it's clearer. Perhaps even wrapping it inside #ifndef NDEBUG, like this: #ifndef NDEBUG off64_t old_offset = #endif lseek64 (fd, extension_offset, SEEK_SET); -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."