From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6BF873858D37 for ; Tue, 5 Apr 2022 07:09:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6BF873858D37 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-FtB4lgDDPLKTiyUVulibnA-1; Tue, 05 Apr 2022 03:09:28 -0400 X-MC-Unique: FtB4lgDDPLKTiyUVulibnA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BFBE1185A794; Tue, 5 Apr 2022 07:09:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8A00145D47D; Tue, 5 Apr 2022 07:09:26 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v3] linux: Fix __closefrom_fallback iterates until max int (BZ#28993) References: <20220404210131.702898-1-adhemerval.zanella@linaro.org> Date: Tue, 05 Apr 2022 09:09:25 +0200 In-Reply-To: <20220404210131.702898-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 4 Apr 2022 18:01:31 -0300") Message-ID: <87r16c2ehm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 07:09:32 -0000 * Adhemerval Zanella via Libc-alpha: > The __closefrom_fallback tries to get a available file descriptor > if the initial open ("/proc/self/fd/", ...) fails. It assumes the > failure would be only if procfs is not mount (ENOENT), however if > the the proc file is not accessible (due some other kernel filtering > such apparmor) it will iterate over a potentially large file set > issuing close calls. > > It should only try the close fallback if open returns EMFILE. The last line no longer matches the patch. Rest looks okay. Thanks, Florian