public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] Remove dl-librecon.h header.
Date: Mon, 28 Feb 2022 20:11:39 +0100	[thread overview]
Message-ID: <87r17mrel0.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220221175922.3909198-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 21 Feb 2022 14:59:22 -0300")

* Adhemerval Zanella via Libc-alpha:

> diff --git a/elf/dl-support.c b/elf/dl-support.c
> index 1d648ce3a6..fa9fcdbe5a 100644
> --- a/elf/dl-support.c
> +++ b/elf/dl-support.c

> @@ -370,15 +367,9 @@ _dl_non_dynamic_init (void)
>  
>    if (__libc_enable_secure)
>      {
> -      static const char unsecure_envvars[] =
> -	UNSECURE_ENVVARS
> -#ifdef EXTRA_UNSECURE_ENVVARS
> -	EXTRA_UNSECURE_ENVVARS
> -#endif
> -	;
> -      const char *cp = unsecure_envvars;
> +      const char *cp = UNSECURE_ENVVARS;
>  
> -      while (cp < unsecure_envvars + sizeof (unsecure_envvars))
> +      while (cp < UNSECURE_ENVVARS + sizeof (UNSECURE_ENVVARS))
>  	{
>  	  __unsetenv (cp);
>  	  cp = (const char *) __rawmemchr (cp, '\0') + 1;

Please keep unsecure_envvars.  I think C does not guarantee that there
is just one array for UNSECURE_ENVVARS.

Rest looks okay to me.

Thanks,
Florian


  reply	other threads:[~2022-02-28 19:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 17:59 [PATCH 0/2] Remove distinguish library code Adhemerval Zanella
2022-02-21 17:59 ` [PATCH 1/2] Remove kernel version check Adhemerval Zanella
2022-02-28 19:00   ` Florian Weimer
2022-03-04 12:42     ` Adhemerval Zanella
2022-02-21 17:59 ` [PATCH 2/2] Remove dl-librecon.h header Adhemerval Zanella
2022-02-28 19:11   ` Florian Weimer [this message]
2022-03-04 12:42     ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r17mrel0.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).