From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E47443858C27 for ; Fri, 24 Dec 2021 12:42:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E47443858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-111-9_OSG29XM5yBOV4ZLaXX_Q-1; Fri, 24 Dec 2021 07:42:48 -0500 X-MC-Unique: 9_OSG29XM5yBOV4ZLaXX_Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 389FA593A8; Fri, 24 Dec 2021 12:42:47 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE13D5FC08; Fri, 24 Dec 2021 12:42:45 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v7 05/16] elf: Add _dl_audit_symbind_alt and _dl_audit_symbind References: <20211222132712.523295-1-adhemerval.zanella@linaro.org> <20211222132712.523295-6-adhemerval.zanella@linaro.org> Date: Fri, 24 Dec 2021 13:42:43 +0100 In-Reply-To: <20211222132712.523295-6-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 22 Dec 2021 10:27:01 -0300") Message-ID: <87r1a29nss.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2021 12:42:51 -0000 * Adhemerval Zanella: > It consolidates the code required to call la_symbind{32,64} audit > callback. > > Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. > --- > elf/Versions | 1 + > elf/dl-audit.c | 122 +++++++++++++++++++++++++++++++++++++ > elf/dl-runtime.c | 79 +----------------------- > elf/dl-sym-post.h | 47 +------------- > sysdeps/generic/ldsodefs.h | 10 +++ > 5 files changed, 135 insertions(+), 124 deletions(-) Looks good to me. Reviewed-by: Florian Weimer Thanks, Florian