From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 694E23858412 for ; Wed, 24 Nov 2021 09:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 694E23858412 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-28-shdGY69dPw642eboQch2-Q-1; Wed, 24 Nov 2021 04:52:17 -0500 X-MC-Unique: shdGY69dPw642eboQch2-Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C17C681EE62; Wed, 24 Nov 2021 09:52:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C37C4ABAF; Wed, 24 Nov 2021 09:52:15 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Samuel Thibault , Adhemerval Zanella , Sergey Bugaev Subject: Re: [PATCH v2] io: Refactor close_range and closefrom References: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> Date: Wed, 24 Nov 2021 10:52:13 +0100 In-Reply-To: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 8 Nov 2021 14:28:17 -0300") Message-ID: <87r1b5op82.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 09:52:22 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/include/unistd.h b/include/unistd.h > index 7849562c42..927d249380 100644 > --- a/include/unistd.h > +++ b/include/unistd.h > @@ -3,6 +3,9 @@ > > # ifndef _ISOMAC > > +# include > +# include > + > libc_hidden_proto (_exit, __noreturn__) > # ifndef NO_RTLD_HIDDEN > rtld_hidden_proto (_exit, __noreturn__) > @@ -158,7 +161,14 @@ extern int __brk (void *__addr) attribute_hidden; > extern int __close (int __fd); > libc_hidden_proto (__close) > extern int __libc_close (int __fd); > +#if __ASSUME_CLOSE_RANGE > +static inline _Bool __closefrom_fallback (int __lowfd, _Bool dirfd_fallback) > +{ > + return false; > +} > +#else > extern _Bool __closefrom_fallback (int __lowfd, _Bool) attribute_hidden; > +#endif > extern ssize_t __read (int __fd, void *__buf, size_t __nbytes); > libc_hidden_proto (__read) > extern ssize_t __write (int __fd, const void *__buf, size_t __n); #if indentation seems off. I expect this will break the Hurd build because it does not define __ASSUME_CLOSE_RANGE in its . Thanks, Florian