From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 9D45F3858416
 for <libc-alpha@sourceware.org>; Fri, 29 Oct 2021 09:27:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D45F3858416
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-65-S0IfuvT5PU-UIWk6rFQPow-1; Fri, 29 Oct 2021 05:27:12 -0400
X-MC-Unique: S0IfuvT5PU-UIWk6rFQPow-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C19AD80668C;
 Fri, 29 Oct 2021 09:27:11 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.194.250])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 9199019D9B;
 Fri, 29 Oct 2021 09:27:10 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org,  "Richard W . M . Jones" <rjones@redhat.com>
Subject: Re: [COMMITTED] Handle NULL input to malloc_usable_size [BZ #28506]
References: <87v91gjj41.fsf@oldenburg.str.redhat.com>
 <20211029092538.2215865-1-siddhesh@sourceware.org>
Date: Fri, 29 Oct 2021 11:27:08 +0200
In-Reply-To: <20211029092538.2215865-1-siddhesh@sourceware.org> (Siddhesh
 Poyarekar's message of "Fri, 29 Oct 2021 14:55:38 +0530")
Message-ID: <87r1c4ji4z.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=unavailable autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Oct 2021 09:27:17 -0000

* Siddhesh Poyarekar:

> Hoist the NULL check for malloc_usable_size into its entry points in
> malloc-debug and malloc and assume non-NULL in all callees.  This fixes
> BZ #28506
>
> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> Reviewed-by: Richard W.M. Jones <rjones@redhat.com>

Looks good, thanks.

Florian