public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Lucas A. M. Magalhaes via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>,  tuliom@linux.ibm.com
Subject: Re: [PATCH] powerpc: Use the correct flag for 32-bit known libraries
Date: Mon, 25 Oct 2021 20:22:00 +0200	[thread overview]
Message-ID: <87r1c9rmlz.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211022211201.983646-1-lamm@linux.ibm.com> (Lucas A. M. Magalhaes via Libc-alpha's message of "Fri, 22 Oct 2021 18:12:01 -0300")

* Lucas A. M. Magalhaes via Libc-alpha:

> In systems with more versions of the known libraries, i.e. on IBM
> Advance Toolchain, ldconfig will order them incorrectly on ld.cache.
>
> The issue only occurs with 32-bit libraries that don't depend on libc or
> libm. That's because process_elf32_file check if the elf depends on one
> of the libraries at known_libs to select the elf flag. For example, as
> libc.so.6 don't depend on itself or on libm it will be flagged as
> FLAG_ELF instead of FLAG_LIBC6 as expected.

FLAG_ELF_LIBC6 instead of FLAG_LIBC6.

I have not looked at this patch in detail.  I would prefer if we removed
unified cache support for libc.so.4, libc.so.5 and always wrote
FLAG_ELF_LIBC6 to the cache instead.  The older Linux libcs have been
obsolete for more than twenty years.  I do not know how much work this
would be, so if someone can review your patch and it can go in, that's
fine with me.

Thanks,
Florian


  reply	other threads:[~2021-10-25 18:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 21:12 Lucas A. M. Magalhaes
2021-10-25 18:22 ` Florian Weimer [this message]
2021-12-22 15:31   ` [RFC] Remove special flags of libc.5.so and libc.4.so Lucas A. M. Magalhaes
2022-01-10 19:21     ` Lucas A. M. Magalhaes
2022-01-11 19:22     ` Adhemerval Zanella
2022-03-02 19:37       ` Raoni Fassina Firmino
2022-03-04 18:38         ` Adhemerval Zanella
2022-02-23 22:17     ` Raoni Fassina Firmino
2021-11-04 18:10 ` [PATCH] powerpc: Use FLAG_ELF_LIBC6 for 32-bit known libraries Lucas A. M. Magalhaes
2021-12-03 12:40   ` Lucas A. M. Magalhaes
2021-12-03 14:17   ` Florian Weimer
2021-12-03 14:51   ` Adhemerval Zanella
2022-03-02 19:30     ` Raoni Fassina Firmino
2022-03-04 18:49       ` Adhemerval Zanella
2022-02-23 22:09   ` Raoni Fassina Firmino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1c9rmlz.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=lamm@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=tuliom@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).