From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 74E41385841C for ; Mon, 30 Aug 2021 15:37:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74E41385841C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-taXCh_UHO-KBptyELee2JA-1; Mon, 30 Aug 2021 11:37:42 -0400 X-MC-Unique: taXCh_UHO-KBptyELee2JA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8EF21015187; Mon, 30 Aug 2021 15:37:41 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C42A60CD1; Mon, 30 Aug 2021 15:37:40 +0000 (UTC) From: Florian Weimer To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org, samuel.thibault@gnu.org Subject: Re: [RFC PATCH htl v2 0/4] Rewrite THREAD_GSCOPE References: <20210830152636.1334678-1-bugaevc@gmail.com> Date: Mon, 30 Aug 2021 17:37:38 +0200 In-Reply-To: <20210830152636.1334678-1-bugaevc@gmail.com> (Sergey Bugaev's message of "Mon, 30 Aug 2021 18:26:32 +0300") Message-ID: <87r1ebndtp.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 15:37:45 -0000 * Sergey Bugaev: > I can think of two ways this can be handled: > > * Code can be rewritten and reorganized to use port-specific files instead of > conditional compilation. From looking at how glibc source is organized, this > appears to be the generally preferred way. I'm sending one more patch that > makes a (perhaps misguided) attempt to do this; but I'm not sure what would > be good way to handle the definitions in -- please take a look. Yes, that's usually how things are done. > * A more conservative approach would be to leave the code using > THREAD_GSCOPE_IN_TCB as is for now, but change the variable's name to > better reflect what it's used for. I haven't really been able to come > up with a good name, though. You could kick the can down the road by switching to PTHREAD_IN_LIBC. In some cases, that might actually be correct replacement. Thanks, Florian