From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 22/24] resolv: Move res_query functions into libc
Date: Wed, 21 Jul 2021 12:16:11 +0200 [thread overview]
Message-ID: <87r1fsnf9w.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87o8awq9eg.fsf@igel.home> (Andreas Schwab's message of "Wed, 21 Jul 2021 11:54:47 +0200")
* Andreas Schwab:
> fedfs-utils wants __res_querydomain. Do we want to support this?
>
> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc:rebuild/fedfs-utils/f/x86_64
The configure test looks like this:
AC_CHECK_LIB([resolv], [__res_querydomain],
[AC_SUBST([LIBRESOLV], ["-lresolv"])
AC_DEFINE([HAVE_LIBRESOLV], [1],
[Define if you have libresolv])],
[AC_MSG_ERROR([libresolv not found.])])
The AC_MSG_ERROR probably needs to be removed. HAVE_LIBRESOLV is
unused, and LIBRESOLV is not needed if __res_querydomain is not
available (because res_querydomain is in libc).
I'm not sure if we need to cater to such configure tests. In my
opinion, if programmers want to check for the presence of such
(non-POSIX) functions, they need to include <resolv.h> and use an
appropriate source code fragment.
As far as I can see, other software (emacs, mtr, sendmail) checks both
__res_* and res_* names and should be fine with __res_* as compat
symbols.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-21 10:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 9:08 [PATCH v3 00/24] Move nss_dns and parts of libresolv " Florian Weimer
2021-07-15 9:09 ` [PATCH 01/24] resolv: Deprecate legacy interfaces in libresolv Florian Weimer
2021-07-15 9:30 ` Andreas Schwab
2021-07-15 9:32 ` Florian Weimer
2021-07-19 1:48 ` Carlos O'Donell
2021-07-15 9:09 ` [PATCH 02/24] resolv: Move ns_name_skip to its own file and into libc (bug 28091) Florian Weimer
2021-07-19 1:52 ` Carlos O'Donell
2021-07-15 9:09 ` [PATCH 03/24] resolv: Move ns_name_uncompress into its own file and into libc Florian Weimer
2021-07-15 9:09 ` [PATCH 04/24] resolv: Move ns_name_pton " Florian Weimer
2021-07-15 9:09 ` [PATCH 05/24] resolv: Move ns_name_pack " Florian Weimer
2021-07-15 9:09 ` [PATCH 06/24] resolv: Move ns_name_compress " Florian Weimer
2021-07-15 9:09 ` [PATCH 07/24] resolv: Move dn_expand to " Florian Weimer
2021-07-15 9:09 ` [PATCH 08/24] resolv: Move _getlong, _getshort, __putlong, __putshort to res-putget Florian Weimer
2021-07-15 9:09 ` [PATCH 09/24] resolv: Move dn_comp to its own file and into libc Florian Weimer
2021-07-15 9:09 ` [PATCH 10/24] resolv: Move dn_skipname " Florian Weimer
2021-07-15 9:09 ` [PATCH 11/24] resolv: Rename res_comp.c to res-name-checking.c and move " Florian Weimer
2021-07-15 9:10 ` [PATCH 12/24] resolv: Move __res_get_nsaddr to its own file and " Florian Weimer
2021-07-15 9:10 ` [PATCH 13/24] resolv: Move res_isourserver to its own file and reformat to GNU style Florian Weimer
2021-07-15 9:10 ` [PATCH 14/24] resolv: Move ns_makecanon into its own file, and into libc Florian Weimer
2021-07-15 9:10 ` [PATCH 15/24] resolv: Move ns_samename " Florian Weimer
2021-07-15 9:10 ` [PATCH 16/24] resolv: Move res_nameinquery to its own file " Florian Weimer
2021-07-15 9:10 ` [PATCH 17/24] resolv: Move res_queriesmatch " Florian Weimer
2021-07-15 9:10 ` [PATCH 18/24] resolv: Move __res_context_hostalias into " Florian Weimer
2021-07-15 9:10 ` [PATCH 19/24] resolv: Move res_hostalias into its own file, along with hostalias Florian Weimer
2021-07-15 9:10 ` [PATCH 20/24] resolv: Move res_send, res_nsend into libc Florian Weimer
2021-07-19 1:54 ` Carlos O'Donell
2021-07-15 9:10 ` [PATCH 21/24] resolv: Move res_mkquery, res_nmkquery " Florian Weimer
2021-07-15 9:10 ` [PATCH 22/24] resolv: Move res_query functions " Florian Weimer
2021-07-21 9:54 ` Andreas Schwab
2021-07-21 10:16 ` Florian Weimer [this message]
2021-07-15 9:10 ` [PATCH 23/24] resolv: Move nss_dns " Florian Weimer
2021-07-15 9:11 ` [PATCH 24/24] nss: Directly load nss_dns, without going through dlsym/dlopen Florian Weimer
2021-07-20 9:17 ` [PATCH v3 00/24] Move nss_dns and parts of libresolv into libc Andreas Schwab
2021-07-20 10:26 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1fsnf9w.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).