From: Andreas Schwab <schwab@linux-m68k.org>
To: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>, fweimer@redhat.com
Subject: Re: [PATCH v2 03/10] Move glibc.malloc.check implementation into its own file
Date: Wed, 30 Jun 2021 17:42:17 +0200 [thread overview]
Message-ID: <87r1gjqrza.fsf@igel.home> (raw)
In-Reply-To: <20210630151921.2752628-4-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Wed, 30 Jun 2021 20:49:14 +0530")
On Jun 30 2021, Siddhesh Poyarekar via Libc-alpha wrote:
> diff --git a/malloc/Makefile b/malloc/Makefile
> index c8256abbbf..9b92f96813 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -272,6 +272,7 @@ $(objpfx)memusage: memusage.sh
>
> # Extra dependencies
> $(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
> +hooks.c: malloc-check.c
This is wrong. The file hooks.c is not a generated file, and does not
depend on malloc-check.c.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-06-30 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 15:19 [PATCH v2 00/10] Remove malloc hooks Siddhesh Poyarekar
2021-06-30 15:19 ` [PATCH v2 01/10] mtrace: Deprecate mallwatch and tr_break Siddhesh Poyarekar
2021-07-01 21:53 ` DJ Delorie
2021-06-30 15:19 ` [PATCH v2 02/10] Add mcheck tests to malloc Siddhesh Poyarekar
2021-07-01 22:14 ` DJ Delorie
2021-06-30 15:19 ` [PATCH v2 03/10] Move glibc.malloc.check implementation into its own file Siddhesh Poyarekar
2021-06-30 15:42 ` Andreas Schwab [this message]
2021-06-30 15:56 ` Siddhesh Poyarekar
2021-06-30 16:13 ` Andreas Schwab
2021-06-30 16:23 ` Siddhesh Poyarekar
2021-06-30 15:19 ` [PATCH v2 04/10] malloc: Move malloc hook references to hooks.c Siddhesh Poyarekar
2021-06-30 15:19 ` [PATCH v2 05/10] glibc.malloc.check: Wean away from malloc hooks Siddhesh Poyarekar
2021-06-30 15:19 ` [PATCH v2 06/10] mcheck: " Siddhesh Poyarekar
2021-07-01 22:31 ` DJ Delorie
2021-06-30 15:19 ` [PATCH v2 07/10] mtrace: " Siddhesh Poyarekar
2021-07-01 22:44 ` DJ Delorie
2021-06-30 15:19 ` [PATCH v2 08/10] Remove " Siddhesh Poyarekar
2021-07-01 22:47 ` DJ Delorie
2021-06-30 15:19 ` [PATCH v2 09/10] Remove __after_morecore_hook Siddhesh Poyarekar
2021-06-30 15:19 ` [PATCH v2 10/10] Remove __morecore and __default_morecore Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1gjqrza.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).