From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E2AD13951015 for ; Mon, 28 Jun 2021 08:52:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E2AD13951015 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-Rr9xHrn5NHewOXV8mELdsA-1; Mon, 28 Jun 2021 04:52:28 -0400 X-MC-Unique: Rr9xHrn5NHewOXV8mELdsA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6AA64362F9; Mon, 28 Jun 2021 08:52:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A442A10016FE; Mon, 28 Jun 2021 08:52:26 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v4 4/4] posix: Add _Fork [BZ #4737] References: <20210623184354.395316-1-adhemerval.zanella@linaro.org> <20210623184354.395316-5-adhemerval.zanella@linaro.org> <87y2azlkdj.fsf@oldenburg.str.redhat.com> <57a719b0-b2eb-3892-6ec1-5267a5fef6b7@linaro.org> Date: Mon, 28 Jun 2021 10:52:24 +0200 In-Reply-To: <57a719b0-b2eb-3892-6ec1-5267a5fef6b7@linaro.org> (Adhemerval Zanella's message of "Thu, 24 Jun 2021 10:34:29 -0300") Message-ID: <87r1gmxtfb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 08:52:32 -0000 * Adhemerval Zanella: > For returns_twice we have __attribute_returns_twice__, but I think we might > want to add it on multiple symbols (not only on _Fork). So I haven't it added > for now. I was wondering if gcc knows about these functions. It does actually for fork, but it uses that only for gcov as far as I can see. > Below it is an updated patch based on your comments, is this one ok to > commit? This patch looks reasonable to me. Thanks, Florian