From: Andreas Schwab <schwab@linux-m68k.org>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: v5 [PATCH 6/6] nsswitch: use new internal API (callers)
Date: Tue, 16 Feb 2021 09:38:31 +0100 [thread overview]
Message-ID: <87r1lgquew.fsf@igel.home> (raw)
In-Reply-To: <xn8s7oagd7.fsf@greed.delorie.com> (DJ Delorie's message of "Mon, 15 Feb 2021 21:36:20 -0500")
On Feb 15 2021, DJ Delorie wrote:
> Andreas Schwab <schwab@linux-m68k.org> writes:
>> This makes nss_compat non-functional.
>
> Since you have a way to test it, and have not included a reproducer,
> could you please test this patch?
nss_compat needs the {passwd,group,shadow}_compat databases, which
__nss_database_lookup2 doesn't recognize.
> + /* Primary name not found, try alternate. */
> + for (database_id = 0; database_names[database_id]; database_id++)
> + if (strcmp (database_names[database_id], alternate_name) == 0)
> + if (__nss_database_get (database_id, ni) && *ni != NULL)
> + return 0;
That crashes if alternate_name is NULL.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-02-16 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 20:34 DJ Delorie
2020-12-04 3:29 ` Siddhesh Poyarekar
2021-02-15 15:42 ` Andreas Schwab
2021-02-16 2:36 ` DJ Delorie
2021-02-16 8:38 ` Andreas Schwab [this message]
2021-02-17 5:42 ` DJ Delorie
2021-02-17 13:27 ` Andreas Schwab
2021-02-17 20:44 ` DJ Delorie
2021-02-17 21:09 ` Andreas Schwab
2021-02-17 21:15 ` DJ Delorie
2021-02-17 22:31 ` Andreas Schwab
2021-02-17 22:51 ` DJ Delorie
2021-02-17 23:23 ` Andreas Schwab
2021-02-18 4:55 ` DJ Delorie
2021-02-18 8:43 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1lgquew.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).