From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 7E5333985463 for ; Tue, 3 Nov 2020 15:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E5333985463 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-eNTMc0lqMyy6iPrBOW7wZQ-1; Tue, 03 Nov 2020 10:30:22 -0500 X-MC-Unique: eNTMc0lqMyy6iPrBOW7wZQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CAADC106B1D4; Tue, 3 Nov 2020 15:29:35 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-12.ams2.redhat.com [10.36.113.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A6A021E97; Tue, 3 Nov 2020 15:29:34 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 24/28] elf: Implement a string table for ldconfig, with tail merging References: <2fa948f4-4cc9-750d-3282-7df1d4dd4498@linaro.org> <87v9erk5fx.fsf@oldenburg2.str.redhat.com> <21aa83aa-ad91-41dc-cdd5-666226fa9779@linaro.org> Date: Tue, 03 Nov 2020 16:29:33 +0100 In-Reply-To: <21aa83aa-ad91-41dc-cdd5-666226fa9779@linaro.org> (Adhemerval Zanella's message of "Tue, 3 Nov 2020 10:05:22 -0300") Message-ID: <87r1pa8nmq.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 15:30:25 -0000 * Adhemerval Zanella: >>>> +struct stringtable_entry * >>>> +stringtable_intern (struct stringtable *table, const char *string) >>>> +{ >>>> + if (table->allocated == 0) >>>> + stringtable_init (table); >>> >>> How this could happen? Is it expect the caller to set 'allocated' >>> explicitly? >> >> Zero-initialization is valid. stringtable_free also leaves the table >> ready for re-use. > > Wouldn't both usages make the above check unnecessary? Doubling zero is still zero, so the growth code path doesn't work. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill