From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 951563942021 for ; Wed, 14 Oct 2020 14:08:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 951563942021 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-lZkLdUdQNW2hOoM7YOrNkg-1; Wed, 14 Oct 2020 10:08:56 -0400 X-MC-Unique: lZkLdUdQNW2hOoM7YOrNkg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B8AEA1029D22; Wed, 14 Oct 2020 14:08:54 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-103.ams2.redhat.com [10.36.114.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E2246EF5A; Wed, 14 Oct 2020 14:08:53 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 20/28] aarch64: Add glibc-hwcaps support References: <90b5f27a-9da8-76b0-b12d-907dcd7f7c0c@linaro.org> Date: Wed, 14 Oct 2020 16:08:52 +0200 In-Reply-To: <90b5f27a-9da8-76b0-b12d-907dcd7f7c0c@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 14 Oct 2020 10:46:11 -0300") Message-ID: <87r1q0oq6j.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 14:08:59 -0000 * Adhemerval Zanella via Libc-alpha: > On 01/10/2020 13:33, Florian Weimer via Libc-alpha wrote: >> At this point, only the "atomics" subdirectory is available, >> for libraries built using LSE atomics. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Thanks. I didn't want to skip AArch64, but it's really more of a stub implementation: >> +const char _dl_hwcaps_subdirs[] = "atomics"; Does this still make sense with GCC defaulting to -moutline-atomics for ARMv8a? That's what I wonder. Eventually, we need to define some levels for AArch64, and I'm not sure to what extent they would align with the official 8.X versions. To me, they look more like a bouquet you can choose from. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill