From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 97E0B3857C78 for ; Fri, 9 Oct 2020 08:56:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97E0B3857C78 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-x6X9C1--NFGkQZ8b_-AvEQ-1; Fri, 09 Oct 2020 04:56:26 -0400 X-MC-Unique: x6X9C1--NFGkQZ8b_-AvEQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9505F1084C97; Fri, 9 Oct 2020 08:56:25 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE62F76672; Fri, 9 Oct 2020 08:56:24 +0000 (UTC) From: Florian Weimer To: "Paul A. Clarke" Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 16/28] elf: Add glibc-hwcaps support for LD_LIBRARY_PATH References: <47cb6998ed91f70f122de115b2e03ea5e82e5884.1601569371.git.fweimer@redhat.com> <20201008231611.GA44221@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> Date: Fri, 09 Oct 2020 10:56:23 +0200 In-Reply-To: <20201008231611.GA44221@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (Paul A. Clarke's message of "Thu, 8 Oct 2020 18:16:11 -0500") Message-ID: <87r1q7dbgo.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 08:56:29 -0000 * Paul A. Clarke: >> + /* Sum of the individual substring lengths (without separates or > > separators? Fixed. >> + /* glibc-hwcaps subdirectories. These are exempted from the power >> + set construction below below. */ > > remove one "below" :-) Done. >> +/* Prepare *S for iteration with _dl_hwcaps_split_masked. Only HWCAP >> + names in SUBJECT whose bit is set in BITMASK and whose ane is in > > s/ane/name/ ? Right, fixed. I'll try to address the other comments and repost. Thanks. Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill