From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id E74E73858D35
 for <libc-alpha@sourceware.org>; Wed,  7 Oct 2020 16:49:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E74E73858D35
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1kQCdP-0000dM-Me; Wed, 07 Oct 2020 16:49:47 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1kQCdP-0001Ih-JM; Wed, 07 Oct 2020 18:49:47 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 06/28] elf: Record whether paths come from LD_LIBRARY_PATH
 or --library-path
References: <cover.1601569371.git.fweimer@redhat.com>
 <ab35cf9efe79980a59e58ed59fdadcd8084941be.1601569371.git.fweimer@redhat.com>
 <31804d39-0208-adb1-cbcd-963fbba64c9f@linaro.org>
Date: Wed, 07 Oct 2020 18:49:47 +0200
In-Reply-To: <31804d39-0208-adb1-cbcd-963fbba64c9f@linaro.org> (Adhemerval
 Zanella via Libc-alpha's message of "Wed, 7 Oct 2020 13:39:41 -0300")
Message-ID: <87r1qa3rro.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2020 16:49:51 -0000

* Adhemerval Zanella via Libc-alpha:

> On 01/10/2020 13:32, Florian Weimer via Libc-alpha wrote:
>> This allows more precise diagnostics.
>
> I haven't check the rest of the patchset to see how this information
> would be used, but one option might to define the source with an 
> enumeration instead of an string (to fully use a type and avoid wrong
> usage).

It's immediately used by the existing LD_DEBUG diagnostics (those that
currently show LD_LIBRARY_PATH, RUNPATH, RPATH).

>> +  /* Where library_path comes from.  LD_LIBRARY_PATH or --library.  */

>> +	    state.library_path_source = "--library_path";

I'm going to fix those typos before comitting.