From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 419DF385E83A for ; Thu, 1 Oct 2020 09:01:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 419DF385E83A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C26ZB71fVz1rxLX; Thu, 1 Oct 2020 11:01:54 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C26ZB6Y01z1qwSx; Thu, 1 Oct 2020 11:01:54 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id hJsaRAUKd-dU; Thu, 1 Oct 2020 11:01:54 +0200 (CEST) X-Auth-Info: gQDo4moQO6ObnUOMKQnG9uy3bTioR4fA76EFxDVD9aQGeCxqdZa8okiYybuaBjf1 Received: from igel.home (ppp-46-244-181-127.dynamic.mnet-online.de [46.244.181.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 1 Oct 2020 11:01:54 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id A37702C0A8E; Thu, 1 Oct 2020 11:01:53 +0200 (CEST) From: Andreas Schwab To: Tulio Magno Quites Machado Filho via Libc-alpha Cc: Tulio Magno Quites Machado Filho , amodra@gmail.com Subject: Re: [PATCH] powerpc64: Implement TLS using PC-relative addressing References: <20200930195512.724059-1-tuliom@linux.ibm.com> X-Yow: WHOA!! Ken and Barbie are having TOO MUCH FUN!! It must be the NEGATIVE IONS!! Date: Thu, 01 Oct 2020 11:01:53 +0200 In-Reply-To: <20200930195512.724059-1-tuliom@linux.ibm.com> (Tulio Magno Quites Machado Filho via Libc-alpha's message of "Wed, 30 Sep 2020 16:55:12 -0300") Message-ID: <87r1qi2ubi.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 09:01:57 -0000 On Sep 30 2020, Tulio Magno Quites Machado Filho via Libc-alpha wrote: > diff --git a/sysdeps/powerpc/mod-tlsopt-powerpc.c b/sysdeps/powerpc/mod-tlsopt-powerpc.c > index ee0db12a73..5856dab60b 100644 > --- a/sysdeps/powerpc/mod-tlsopt-powerpc.c > +++ b/sysdeps/powerpc/mod-tlsopt-powerpc.c > @@ -24,7 +24,14 @@ tls_get_addr_opt_test (void) > tls_index *tls_arg; > #ifdef __powerpc64__ > register unsigned long thread_pointer __asm__ ("r13"); > + /* PC-relative addressing is available when compiling with -mpcrel. > + The first releases of GCC 10 do support -mpcrel, but do not export > + __PCREL__. */ > +# if defined(__PCREL__) || __GNUC__ <= 10 && defined(_ARCH_PWR10) Space after defined, and remove the parens. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."