From: Florian Weimer <fw@deneb.enyo.de>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org, amonakov@ispras.ru, schwab@linux-m68k.org
Subject: Re: [patch] Use unsigned constants for ICMP6 filters [BZ #22489]
Date: Sun, 03 May 2020 22:23:04 +0200 [thread overview]
Message-ID: <87r1w0ix93.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <xn8sic8zux.fsf@greed.delorie.com> (DJ Delorie's message of "Thu, 30 Apr 2020 16:47:50 -0400")
* DJ Delorie:
> The core problem here is that the filter array is unsigned but the
> computed constants are signed. This both causes a signededness
> conversion at the &= step and may cause undefined behavior if the MSB
> is being modified. This patch uses unsigned constants to avoid both
> cases. - DJ
I'd say that the filter array *elements* are unsigned, but I don't
feel strongly about that.
next prev parent reply other threads:[~2020-05-03 20:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 21:35 DJ Delorie
2020-04-25 8:53 ` Andreas Schwab
2020-04-25 17:15 ` DJ Delorie
2020-04-25 17:48 ` Andreas Schwab
2020-04-25 21:23 ` DJ Delorie
2020-04-25 21:30 ` Andreas Schwab
2020-04-25 21:41 ` DJ Delorie
2020-04-26 11:25 ` Alexander Monakov
2020-04-26 11:56 ` Florian Weimer
2020-04-30 20:47 ` DJ Delorie
2020-05-03 20:23 ` Florian Weimer [this message]
2020-05-08 20:10 ` DJ Delorie
2020-05-08 20:22 ` Florian Weimer
2020-05-11 21:09 ` DJ Delorie
2020-05-12 7:35 ` Andreas Schwab
2020-04-26 8:03 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1w0ix93.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=amonakov@ispras.ru \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).