public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: Alan Modra <amodra@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 4/6] strncpy, stpncpy and strstr fixes
Date: Mon, 12 Jun 2017 19:55:00 -0000	[thread overview]
Message-ID: <87r2ypc794.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170601131017.GJ8842@bubble.grove.modra.org>

Alan Modra <amodra@gmail.com> writes:

> Makes __stpncpy_power8 call __memset_power8 directly rather than via an
> IFUNC.  Fixes a missing _mcount, and removes some redundant NOPS.  The
> *_is_local defines are also used in a followup patch.
>
> 	* sysdeps/powerpc/powerpc64/multiarch/strncpy-power7.S: Define
> 	MEMSET_is_local.
> 	* sysdeps/powerpc/powerpc64/multiarch/strncpy-power8.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/multiarch/stpncpy-power7.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/multiarch/stpncpy-power8.S: Likewise.
> 	Define MEMSET.
> 	* sysdeps/powerpc/powerpc64/multiarch/strstr-power7.S: Define
> 	STRLEN_is_local, STRNLEN_is_local, and STRCHR_is_local.
> 	* sysdeps/powerpc/powerpc64/power7/strstr.S: Likewise.  Don't add
> 	nop after local calls.
> 	* sysdeps/powerpc/powerpc64/power7/strncpy.S: Define MEMSET_is_local.
> 	Don't add nop after local call.
> 	* sysdeps/powerpc/powerpc64/power8/strncpy.S: Likewise.  Add missing
> 	CALL_MCOUNT.

Looks good to me.

-- 
Tulio Magno

  reply	other threads:[~2017-06-12 19:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 13:04 [PATCH 0/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY Alan Modra
2017-06-01 13:08 ` [PATCH 1/6] PowerPC64, fix calls to _mcount Alan Modra
2017-06-12 18:07   ` Tulio Magno Quites Machado Filho
2017-06-01 13:09 ` [PATCH 2/6] PowerPC64 FRAME_PARM_SAVE Alan Modra
2017-06-12 18:07   ` Tulio Magno Quites Machado Filho
2017-06-01 13:09 ` [PATCH 3/6] PowerPC64 sysdep.h tidy Alan Modra
2017-06-12 18:12   ` Tulio Magno Quites Machado Filho
2017-06-13  1:27     ` Alan Modra
2017-06-13 17:05       ` Tulio Magno Quites Machado Filho
2017-06-01 13:10 ` [PATCH 4/6] strncpy, stpncpy and strstr fixes Alan Modra
2017-06-12 19:55   ` Tulio Magno Quites Machado Filho [this message]
2017-06-01 13:11 ` [PATCH 5/6] PowerPC64 ENTRY_TOCLESS Alan Modra
2017-06-13 12:23   ` Tulio Magno Quites Machado Filho
2017-06-13 14:46     ` Alan Modra
2017-06-13 17:07       ` Tulio Magno Quites Machado Filho
2017-06-01 13:11 ` [PATCH 6/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY Alan Modra
2017-06-03  4:46   ` Alan Modra
2017-06-13 18:21     ` Tulio Magno Quites Machado Filho
2017-06-14  8:53       ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2ypc794.fsf@linux.vnet.ibm.com \
    --to=tuliom@linux.vnet.ibm.com \
    --cc=amodra@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).