From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44164 invoked by alias); 7 Apr 2016 18:36:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 44149 invoked by uid 89); 7 Apr 2016 18:36:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: e24smtp03.br.ibm.com X-IBM-Helo: d24dlp01.br.ibm.com X-IBM-MailFrom: tuliom@linux.vnet.ibm.com X-IBM-RcptTo: libc-alpha@sourceware.org From: "Tulio Magno Quites Machado Filho" To: "Paul E. Murphy" , "libc-alpha\@sourceware.org" Cc: Subject: Re: [PATCH v3] powerpc: Add optimized P8 strspn In-Reply-To: <5702A88A.7060507@linux.vnet.ibm.com> References: <5702A88A.7060507@linux.vnet.ibm.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Thu, 07 Apr 2016 18:36:00 -0000 Message-ID: <87r3eh8dvr.fsf@totoro.br.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040718-0025-0000-0000-000009121AB4 X-SW-Source: 2016-04/txt/msg00112.txt.bz2 "Paul E. Murphy" writes: > diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile > index 3b0e3a0..7ed56bf 100644 > --- a/sysdeps/powerpc/powerpc64/multiarch/Makefile > +++ b/sysdeps/powerpc/powerpc64/multiarch/Makefile > @@ -19,7 +19,8 @@ sysdep_routines += memcpy-power7 memcpy-a2 memcpy-power6 memcpy-cell \ > strcmp-power8 strcmp-power7 strcmp-ppc64 \ > strcat-power8 strcat-power7 strcat-ppc64 \ > memmove-power7 memmove-ppc64 wordcopy-ppc64 bcopy-ppc64 \ > - strncpy-power8 strstr-power7 strstr-ppc64 > + strncpy-power8 strstr-power7 strstr-ppc64 \ > + strspn-power8 strspn-ppc64 I'm afraid you'll have another conflict here with due to the strlen optimization and the strcasestr optimization. > +/* size_t [r3] strspn (const char *string [r3], > + const char *needleAccept [r4] */ Missing ) here ----------------------------------------^ LGTM. -- Tulio Magno