public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org,  alx.manpages@gmail.com
Subject: Re: [PATCH v3 2/2] Add lint-makefiles Makefile linting test.
Date: Tue, 30 May 2023 15:44:01 +0200	[thread overview]
Message-ID: <87sfberl26.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230530133212.3935551-2-carlos@redhat.com> (Carlos O'Donell's message of "Tue, 30 May 2023 09:32:12 -0400")

* Carlos O'Donell:

> We add a 'make check' test that lints all Makefiles in the source
> directory of the glibc build. This linting test ensures that the
> lines in all Makefiles will be sorted correctly as developers
> creates patches.  It is added to 'make check' because it is
> light-weight and supports the existing developer workflow
>
> The test adds ~3s to a 'make check' execution.
>
> No regressions on x86_64 and i686.
> ---
> v3: Print nothing on success. Use diff -u. Use output as fixit patch.
>  Makefile                  | 10 ++++++
>  scripts/lint-makefiles.sh | 74 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+)
>  create mode 100644 scripts/lint-makefiles.sh

This version looks okay to me.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2023-05-30 13:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 13:32 [PATCH v3 1/2] elf: Sort Makefile variables Carlos O'Donell
2023-05-30 13:32 ` [PATCH v3 2/2] Add lint-makefiles Makefile linting test Carlos O'Donell
2023-05-30 13:44   ` Florian Weimer [this message]
2023-06-03  2:12     ` Carlos O'Donell
2023-06-03  2:12 ` [PATCH v3 1/2] elf: Sort Makefile variables Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfberl26.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=alx.manpages@gmail.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).