From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 071D83858005 for ; Tue, 30 May 2023 13:44:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 071D83858005 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685454245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=COksfWYXNNlo0fimOrlEn7qHKog/fERZpgb4qh+zx1o=; b=fqaGY6GA3AmDbO3dUe/04uPazFgw8yZaVTxhTmdKFQqEtUyXokiq4+xLihKwc2lP7LlYgS eIcS4Dj4BsS+T24QiWO+m4YFAQT0Vf1NyLxzyQOevHxvjsuYkrEGqlhWHk7kFBlPDqHi9k 0N/5uN/FSmXooa+ohTIWiy/88KJN6Fs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-Ys1okzLnN4Suc6vWggXh4Q-1; Tue, 30 May 2023 09:44:04 -0400 X-MC-Unique: Ys1okzLnN4Suc6vWggXh4Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1B6B28237C8; Tue, 30 May 2023 13:44:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23B51492B00; Tue, 30 May 2023 13:44:02 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org, alx.manpages@gmail.com Subject: Re: [PATCH v3 2/2] Add lint-makefiles Makefile linting test. References: <20230530133212.3935551-1-carlos@redhat.com> <20230530133212.3935551-2-carlos@redhat.com> Date: Tue, 30 May 2023 15:44:01 +0200 In-Reply-To: <20230530133212.3935551-2-carlos@redhat.com> (Carlos O'Donell's message of "Tue, 30 May 2023 09:32:12 -0400") Message-ID: <87sfberl26.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Carlos O'Donell: > We add a 'make check' test that lints all Makefiles in the source > directory of the glibc build. This linting test ensures that the > lines in all Makefiles will be sorted correctly as developers > creates patches. It is added to 'make check' because it is > light-weight and supports the existing developer workflow > > The test adds ~3s to a 'make check' execution. > > No regressions on x86_64 and i686. > --- > v3: Print nothing on success. Use diff -u. Use output as fixit patch. > Makefile | 10 ++++++ > scripts/lint-makefiles.sh | 74 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+) > create mode 100644 scripts/lint-makefiles.sh This version looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian