From: Florian Weimer <fw@deneb.enyo.de>
To: John David Anglin <dave@parisc-linux.org>
Cc: libc-alpha@sourceware.org, deller@gmx.de
Subject: Re: [committed] hppa: Drop 16-byte pthread lock alignment
Date: Mon, 27 Mar 2023 02:33:05 +0200 [thread overview]
Message-ID: <87sfdrvxry.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <ZCC3g2nKEtpz36nR@mx3210.localdomain> (John David Anglin's message of "Sun, 26 Mar 2023 21:22:11 +0000")
* John David Anglin:
> hppa: Drop 16-byte pthread lock alignment
>
> Linux threads were removed about 12 years ago and the current
> nptl implementation only requires 4-byte alignment for pthread
> locks.
>
> The 16-byte alignment causes various issues. For example in
> building ignition-msgs, we have:
>
> /usr/include/google/protobuf/map.h:124:37: error: static assertion failed
> 124 | static_assert(alignof(value_type) <= 8, "");
> | ~~~~~~~~~~~~~~~~~~~~^~~~
>
> This is caused by the 16-byte pthread lock alignment.
This was done deliberately to preserve ABI. This change needs a mass
rebuild because struct offsets after pthread_mutex_t members are
likely to change.
next prev parent reply other threads:[~2023-03-27 0:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 21:22 John David Anglin
2023-03-27 0:33 ` Florian Weimer [this message]
2023-03-27 0:37 ` Sam James
2023-03-27 1:58 ` John David Anglin
2023-03-27 12:42 ` Florian Weimer
2023-03-30 21:08 ` John David Anglin
2023-03-31 7:14 ` Florian Weimer
2023-03-27 0:35 ` Sam James
2023-03-27 15:24 ` Pedro Alves
2023-07-06 16:01 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfdrvxry.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=dave@parisc-linux.org \
--cc=deller@gmx.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).