From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 4A1263858D39 for ; Mon, 6 Mar 2023 18:49:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A1263858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <20221227211145.3765256-1-adhemerval.zanella@linaro.org> <20221227211145.3765256-3-adhemerval.zanella@linaro.org> <87bkl5ncob.fsf@aarsen.me> <89b2e6d3-b5e8-6ee1-12e0-22d4c5ca8e06@linaro.org> <8907cf4b-15de-015d-48c3-9a74ad089d30@linaro.org> <35682595-a1c6-851c-c85f-7bcc13cb49ce@linaro.org> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Adhemerval Zanella Netto Cc: Andreas Schwab , Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH v3 2/4] libio: Remove the usage of __libc_IO_vtables Date: Mon, 06 Mar 2023 19:47:30 +0100 In-reply-to: <35682595-a1c6-851c-c85f-7bcc13cb49ce@linaro.org> Message-ID: <87sfehlnq7.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Adhemerval Zanella Netto via Libc-alpha writes: > On 06/03/23 14:24, Adhemerval Zanella Netto wrote: >>=20 >>=20 >> On 06/03/23 13:53, Andreas Schwab wrote: >>> On M=C3=A4r 06 2023, Adhemerval Zanella Netto wrote: >>> >>>> So could be an issue with my patch then? I did not added any new >>>> dependency or rule with this patchset. >>> >>> The new dependency is gen-as-const-headers. >>> >>> I think it adds a cycle because libio-macros.h depends on >>> $(common-objpfx)bits/stdio_lim.h, whereas other gen-as-const-headers >>> don't depend on it. >>=20 >> Right, do we really have to autogenerate stdio_lim.h? It seems that no=20 >> target currently requires to the overrides its values. It would be way= =20 >> simpler if we can assume the sysdeps/posix/Makefile values instead. > > Alright, I could reproduce it and I am not sure how to fix it. This fix > requires libio-macros.sym to correctly setup _IO_file_jumps and=20 > _IO_wfile_jumps alias symbol, and the libio/libio-macros.sym requires to= =20 > know the size ofstruct _IO_jump_t (which in turn uses function pointer=20 > that uses FILE *). > > So libio-macros.sym does require stdio_lim.h in the end. Best solution > I can think of is to just remove stdio_lim.h autogeneration, the only > real system dependent definition is FILENAME_MAX, obtained from kernel > limits.h. I think it should be feasible to just define is a 1024 for > hurd and 4096 for Linux (these should not change in near future and > change it might incur in some compatibility issues). FWIW, I have an interest in making a new port (as time permits...), so please also add an... #else # error "Update the port!" ... or such, if you choose to do that. TIA, have a lovely night. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIcEARYKAC8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZAY1oREcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk8gKAP9KmWj1J5ySONGKNRVZc+KmAZwC8ElLwOr8 omq1pOitZwEAoTcXUd9jIrSnr9lcObFb6C7oN1AKXaAkSj9r6dsRggQ= =UbzS -----END PGP SIGNATURE----- --=-=-=--