From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3389D3858D1E for ; Thu, 10 Nov 2022 13:28:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3389D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668086931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZK5sWVcZLZ7DV/Ex0tUWZeXKY0LCw+GOEzxVpa5/cYM=; b=ATg0odEYodhzUkfRtEWOWVkXMALt3OeM+1zkbr/+4xOST355bS94xG7GqS/g27D7D8rNsu YHl469jNoV7doX7WyOrSQ8pLfTyZvm5hasUCqOTZL+DJ3GVo2znLIaT56BcBF07FfxIpDu xXI8bs6IbbcHxt4XCp7UXZ+8C4zCm4Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-wvvwZi6hNjyk24M611Tx7w-1; Thu, 10 Nov 2022 08:28:50 -0500 X-MC-Unique: wvvwZi6hNjyk24M611Tx7w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90EEC85A5A6; Thu, 10 Nov 2022 13:28:50 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAF00C16922; Thu, 10 Nov 2022 13:28:49 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Linux: Support __IPC_64 in sysvctl *ctl command arguments References: <87bkphij87.fsf@oldenburg.str.redhat.com> Date: Thu, 10 Nov 2022 14:28:48 +0100 In-Reply-To: (Adhemerval Zanella Netto's message of "Thu, 10 Nov 2022 09:27:45 -0300") Message-ID: <87sfirszu7.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 08/11/22 12:00, Florian Weimer via Libc-alpha wrote: >> Old applications pass __IPC_64 as part of the command argument because >> old glibc did not check for unknown commands, and passed through the >> arguments directly to the kernel, without adding __IPC_64. >> Applications need to continue doing that for old glibc compatibility, >> so this commit enables this approach in current glibc. >> >> For msgctl and shmctl, if no translation is required, make >> direct system calls, as we did before the time64 changes. If >> translation is required, mask __IPC_64 from the command argument. >> >> For semctl, the union-in-vararg argument handling means that >> translation is needed on all architectures. >> >> Tested on i686-linux-gnu, powerpc64le-linux-gnu, x86_64-linux-gnu. >> Built with build-many-glibcs.py. > > Sigh, another internal interface that bleed to userpace. The fix sounds > reasonable to compatibility, just a typo below. > > Reviewed-by: Adhemerval Zanella Thanks, pushed with the typo fix. Florian