From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8B2443852751 for ; Tue, 30 Aug 2022 13:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B2443852751 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661866238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qC3iBveovF3ZTzA9nJmjyXJnzkTnSYVQqYmRuSp1ZGE=; b=FFZx4JiGg7se9m63Z/cBf6K1Ku07jiufKP+0kfc3V7mWH/pEbQZ3PADpUVXmOsIpjed+Xf hCU5FuO5PTSMGqnCnngrZoG353oyEaGd3xqf65Bkdk/3783WCGE1zfGJJD49foI0yPSfNe V0+SXi2lH+Sk+YRxrkNOc8dypqiX4i8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-Vb6rju22NtepiTEHHikHvA-1; Tue, 30 Aug 2022 09:30:35 -0400 X-MC-Unique: Vb6rju22NtepiTEHHikHvA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F057D80A0B9; Tue, 30 Aug 2022 13:30:34 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14CAF1415117; Tue, 30 Aug 2022 13:30:33 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto via Libc-alpha Cc: Raphael Moreira Zinsly , Adhemerval Zanella Netto Subject: Re: [PATCH] Apply asm redirections in wchar.h before first use References: <20220824144337.16153-1-rzinsly@linux.ibm.com> <50ba1c79-b88f-bc6b-3bb0-331157ba33e3@linaro.org> Date: Tue, 30 Aug 2022 15:30:32 +0200 In-Reply-To: <50ba1c79-b88f-bc6b-3bb0-331157ba33e3@linaro.org> (Adhemerval Zanella Netto via Libc-alpha's message of "Thu, 25 Aug 2022 13:58:04 -0300") Message-ID: <87sfld505j.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto via Libc-alpha: > On 24/08/22 11:43, Raphael Moreira Zinsly via Libc-alpha wrote: >> Similar to d0fa09a770, but for wchar.h. Fixes [BZ #27087] by applying >> all long double related asm redirections before using functions in >> bits/wchar2.h. >> Moves the function declarations from wcsmbs/bits/wchar2.h to a new file >> wcsmbs/bits/wchar2-decl.h that will be included first in wcsmbs/wchar.h. >> >> Tested with build-many-glibcs.py. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Raphael, could you push this commit, or should we push it on your behalf? Thanks, Florian