From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4F1533858C56 for ; Mon, 11 Jul 2022 12:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F1533858C56 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-4HWu9JmDMxmS_8A-r_zZvw-1; Mon, 11 Jul 2022 08:53:57 -0400 X-MC-Unique: 4HWu9JmDMxmS_8A-r_zZvw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B19D101A56C; Mon, 11 Jul 2022 12:53:57 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33C022166B26; Mon, 11 Jul 2022 12:53:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , Andreas Schwab Subject: Re: [PATCH v7 5/5] linux: Add mount_setattr References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-6-adhemerval.zanella@linaro.org> <0c64445d-a4f7-bb60-d165-e3c02d89549e@redhat.com> <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> <87zghg58qi.fsf@oldenburg.str.redhat.com> <46921EC3-6197-4188-B5C4-F241DE6C1D8F@linaro.org> Date: Mon, 11 Jul 2022 14:53:54 +0200 In-Reply-To: <46921EC3-6197-4188-B5C4-F241DE6C1D8F@linaro.org> (Adhemerval Zanella's message of "Mon, 11 Jul 2022 09:49:46 -0300") Message-ID: <87sfn73j4t.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 12:54:00 -0000 * Adhemerval Zanella: >> On 11 Jul 2022, at 05:55, Florian Weimer wrote: >> >> * Adhemerval Zanella via Libc-alpha: >> >>> I am not sure how to handle it, glibc sys/mount.h should be a standalone >>> header. >> >> Is it really necessary to keep standalone? It's not even >> a standard interface, and we don't have conform tests for this header as >> far as I can see. >> >> So I think the usual __has_include approach should work here, too. > > The main problem is sys/mount.h defines interfaces for syscall added > in multiple releases. It means that depending of the kernel version > used by the compiler we will need to add some defines (for instance > fsconfig_command). There is also a small difference where glibc > header define the MS_* constant as a unnamed enum (not sure if this > affects C++ mangling). You are right, I had missed that. > I know that using kernel headers simplify some support, specially sync > with newer releases; but this also adds more complexity where we need > to handle integration outside glibc project. For openat2, we got a separate header. Maybe we can request that for the fsmount interfaces, too? Than we can do the usual thing just for . can still include , so the change would be transparent. Thanks, Florian