From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7243A3830888 for ; Tue, 28 Jun 2022 11:59:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7243A3830888 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-0uA_oqYZPKeOxvGv3Fs6-Q-1; Tue, 28 Jun 2022 07:59:06 -0400 X-MC-Unique: 0uA_oqYZPKeOxvGv3Fs6-Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33E041C006B0; Tue, 28 Jun 2022 11:59:06 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.0]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 563121415108; Tue, 28 Jun 2022 11:59:05 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v6 02/10] stdlib: Add arc4random tests References: <20220518191424.3630729-1-adhemerval.zanella@linaro.org> <20220518191424.3630729-3-adhemerval.zanella@linaro.org> Date: Tue, 28 Jun 2022 13:59:03 +0200 In-Reply-To: <20220518191424.3630729-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 18 May 2022 16:14:16 -0300") Message-ID: <87sfnpf188.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 11:59:09 -0000 * Adhemerval Zanella: > diff --git a/stdlib/tst-arc4random-chacha20.c b/stdlib/tst-arc4random-cha= cha20.c > new file mode 100644 > index 0000000000..dd0ef6d8ba > --- /dev/null > +++ b/stdlib/tst-arc4random-chacha20.c > @@ -0,0 +1,166 @@ > + . */ https://, not http://. This impacts the other new files. > +#include > +#include > + > +/* It does not define CHACHA20_XOR_FINAL to check what glibc actual uses= . */ Please rephrase what is =E2=80=9Dit=E2=80=9D in this context? Missing spac= e after =E2=80=9D.=E2=80=9D. > + /* Check with the expected internal arc4random keystream buffer. Some > + architecture optimization expectes a buffer with a minimum size of > + multiple of ChaCha20 blocksize, so they might not be prepared to > + handle smaller buffers. */ =E2=80=9Ca minimum size which is a multiple of the ChaCha20 block size=E2= =80=9D? Thanks, Florian