From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 384843858D32
 for <libc-alpha@sourceware.org>; Mon,  9 May 2022 17:08:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 384843858D32
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-596-3cX8FLzuO_mC_0gf4wwuNw-1; Mon, 09 May 2022 13:08:35 -0400
X-MC-Unique: 3cX8FLzuO_mC_0gf4wwuNw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com
 [10.11.54.2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8986385A5A8;
 Mon,  9 May 2022 17:08:35 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.246])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id D561940D2829;
 Mon,  9 May 2022 17:08:34 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v4 3/3] csu: Implement and use _dl_early_allocate during
 static startup
References: <e1affd5497233f02d0401d7bb2227bd27ed229cb.1651762968.git.fweimer@redhat.com>
 <1b8e10100702d11449eb4ec02dbfbaa1db5d4c9f.1651762968.git.fweimer@redhat.com>
 <c6039e9b-742e-0725-d234-66065f49b12e@linaro.org>
 <871qx2adqe.fsf@oldenburg.str.redhat.com>
 <b8bd67ad-4a3f-bc91-287d-080cf1a617c0@linaro.org>
Date: Mon, 09 May 2022 19:08:32 +0200
In-Reply-To: <b8bd67ad-4a3f-bc91-287d-080cf1a617c0@linaro.org> (Adhemerval
 Zanella's message of "Mon, 9 May 2022 13:52:54 -0300")
Message-ID: <87sfpi8whb.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2022 17:08:38 -0000

* Adhemerval Zanella:

> The idea is to allow __mmap64 use the mmap64_call and have the syscall
> logic in one place.  Something like:
>
> void *
> __mmap64 (void *addr, size_t len, int prot, int flags, int fd, off64_t offset)
> {
>   MMAP_CHECK_PAGE_UNIT ();
>
>   if (offset & MMAP_OFF_MASK)
>     return (void *) INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
>
>   MMAP_PREPARE (addr, len, prot, flags, fd, offset);
>   return mmap64_call (addr, len, prot, flags, fd, offset);
> }

With this, a definition of mmap64_call still needs a working definition
of MMAP2_PAGE_UNIT for mmap2 targets, I think.

Thanks,
Florian