From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6A42A3857831 for ; Wed, 4 May 2022 13:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A42A3857831 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-131-omqnXOJkPCKo3xk-ygCGtw-1; Wed, 04 May 2022 09:39:39 -0400 X-MC-Unique: omqnXOJkPCKo3xk-ygCGtw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA332801E80; Wed, 4 May 2022 13:39:38 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D030054ACB4; Wed, 4 May 2022 13:39:37 +0000 (UTC) From: Florian Weimer To: Stefan Liebler Cc: Adhemerval Zanella , Stefan Liebler via Libc-alpha Subject: Re: [PATCH] S390: Enable static PIE References: <20220428141530.567838-1-stli@linux.ibm.com> <87y1zk70vk.fsf@oldenburg.str.redhat.com> <760241d4-2f3e-7078-ad98-a4d8ed3fdc69@linaro.org> <87r15b4ubx.fsf@oldenburg.str.redhat.com> <87pmkufx0s.fsf@oldenburg.str.redhat.com> <25109979-63f6-2a8a-fe19-13bca2f42a6a@linux.ibm.com> Date: Wed, 04 May 2022 15:39:35 +0200 In-Reply-To: <25109979-63f6-2a8a-fe19-13bca2f42a6a@linux.ibm.com> (Stefan Liebler's message of "Wed, 4 May 2022 15:16:58 +0200") Message-ID: <87sfppquw8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 13:39:45 -0000 * Stefan Liebler: > On 03/05/2022 17:36, Florian Weimer wrote: >> * Stefan Liebler: >> >>> I've just build glibc-HEAD and run the testsuite with >>> /proc/sys/kernel/randomize_va_space = 0. => Recognized fails as srbk failed. >>> >>> Then I've build with Florian's patch series on top. I don't see any >>> testsuite fails. Furthermore I've debbugged a static testcase into >>> _dl_early_allocate => mmap was used as result and previous was equal. >>> >>> With Florian's patch series also applied, static PIE binaries also run >>> on an unchanged kernel. >> >> That's great. Then I think this means it's safe to enable static PIE >> for s390x. >> >> Thanks, >> Florian >> > > Thanks. Then I'll add some comments regarding your patch-series to > configure.ac before pushing. > > Shall I wait until your patches are committed or is it okay if I push my > patch before? I think in isolation, it might break the Fedora builders and others. I'll push the three approved patches today and repost the rest later today. Hopefully we can get this resolved by the end of this week. Thanks, Florian