From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 22D603858D37 for ; Tue, 5 Apr 2022 20:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22D603858D37 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-PfAW1dg-OAu23G0FqTLTLg-1; Tue, 05 Apr 2022 16:40:19 -0400 X-MC-Unique: PfAW1dg-OAu23G0FqTLTLg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A9A93C11C7B; Tue, 5 Apr 2022 20:40:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 684AB1121314; Tue, 5 Apr 2022 20:40:18 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= Subject: Re: [PATCH] Remove fno-unit-at-a-time make variable References: <20220330050729.2176630-1-maskray@google.com> <0295bfe2-2f44-c15e-1628-acaf94fc407c@linaro.org> <20220330162311.pwg52gcrr5vnlabe@google.com> <7e7fdfdc-ddc8-cf5a-0525-f927b4ae1e39@linaro.org> <20220331034302.rzcu6gllo7ltkhjh@google.com> <20220404155703.vefk66cwnsnkhsih@google.com> <22f8e3aa-5af9-93a2-65fc-1889674103d6@linaro.org> <4570fa06-24b0-873a-09b6-d57c85dd1191@linaro.org> <914158c4-f52d-21ee-73e5-6ffe30faa0d4@linaro.org> <87k0c3wh6a.fsf@oldenburg.str.redhat.com> <06ae38bd-cccb-9f00-b23a-5a1232a26763@linaro.org> <87zgkzuvim.fsf@oldenburg.str.redhat.com> Date: Tue, 05 Apr 2022 22:40:16 +0200 In-Reply-To: (Adhemerval Zanella's message of "Tue, 5 Apr 2022 17:30:11 -0300") Message-ID: <87sfqruuvj.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 20:40:22 -0000 * Adhemerval Zanella: > On 05/04/2022 17:26, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> On 05/04/2022 14:53, Florian Weimer wrote: >>>> * Adhemerval Zanella via Libc-alpha: >>>> >>>>> This is not what I am seeing on my clang branch, where clang with integrated >>>>> moves the global asm directives to the top of the file. And it makes >>>>> check-abi fail due the _sys_errlist/sys_errlist being with wrong value. >>>> >>>> You can move the directives to the bottom of the file by creating a >>>> temporary .s file and #include that from a wrapper .S file that >>>> #includes the .s file. >>> >>> Not sure I am following your suggestion here, do you mean get the -S >>> output file from compiler? >> >> Yes, H.J. did that in earlier patches. But I didn't like it back then. 8-p > > For dl-debug-symbols.S? I might take it as an example. Yes, here's a link to one of the earlier patches: [PATCH] Extend struct r_debug to support multiple namespaces In the end, I think it was easier to use a manually written assembler file in that case, with the constants filled in via the .sym expander. Thanks, Florian