From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Replace memcmp with __memcmpeq for variable size
Date: Mon, 07 Feb 2022 14:19:33 +0100 [thread overview]
Message-ID: <87sfsuak62.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOp35PmnpLCcjyGkL_XAg1eewbizP2T0nG488wjzP3FDrw@mail.gmail.com> (H. J. Lu's message of "Mon, 7 Feb 2022 05:13:28 -0800")
* H. J. Lu:
>> This must be something else. According to the numbers, we save ~159
>> between ~569 cycles per __memcmpeq call. That is just not realistic.
>
> I removed the cycle info from the commit log.
If we can't show the change is beneficial, is it worth the additional
1000 or so bytes in the loader text?
Thanks,
Florian
next prev parent reply other threads:[~2022-02-07 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 21:09 H.J. Lu
2022-02-06 22:19 ` Florian Weimer
2022-02-07 0:20 ` H.J. Lu
2022-02-07 10:40 ` Florian Weimer
2022-02-07 13:13 ` H.J. Lu
2022-02-07 13:19 ` Florian Weimer [this message]
2022-02-07 13:27 ` H.J. Lu
2022-02-07 13:30 ` Adhemerval Zanella
2022-02-07 14:00 ` H.J. Lu
2022-02-07 20:35 ` Joseph Myers
2022-02-08 22:30 Wilco Dijkstra
2022-02-08 23:00 ` Adhemerval Zanella
2022-02-09 0:07 ` Noah Goldstein
2022-02-09 1:42 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfsuak62.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).