From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A5D853858034 for ; Tue, 18 Jan 2022 13:33:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5D853858034 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-aCPusUSeN96NrB3MD-ZEDA-1; Tue, 18 Jan 2022 08:33:19 -0500 X-MC-Unique: aCPusUSeN96NrB3MD-ZEDA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BF91343CA; Tue, 18 Jan 2022 13:33:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EECF6E20B; Tue, 18 Jan 2022 13:33:17 +0000 (UTC) From: Florian Weimer To: Stefan Liebler Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 7/7] s390x: Use in early HWCAP check References: <201e517c6a751bebe505af99e35a9f8643066f31.1642162312.git.fweimer@redhat.com> <81a3cde1-250e-b04a-0037-4fb7f363fd42@linux.ibm.com> <87czkpjjan.fsf@oldenburg.str.redhat.com> Date: Tue, 18 Jan 2022 14:33:15 +0100 In-Reply-To: (Stefan Liebler's message of "Tue, 18 Jan 2022 14:31:54 +0100") Message-ID: <87sftli2xw.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 13:33:24 -0000 * Stefan Liebler: > On 18/01/2022 13:54, Florian Weimer wrote: >> * Stefan Liebler: >> >>> I'm not quite sure if all your patches are already committed. I've just >>> give it a try with commit f8b765bec44e6c464a7eabf80e58c6851ca15ac3: >>> >>> - configure glibc with --with-rtld-early-cflags=-march=zEC12 and >>> CFLAGS=-march=z15 on a z15. >>> >>> - Rebooted with novx-kernel-parameter => vector-related HWCAPs are >>> disabled and executing vector-instructions leads to a crash >>> >>> - run a helloworld-program: crash due to vector-instruction in >>> _dl_setup_hash, which is called in _dl_start_final before >>> _dl_sysdep_start is called which runs dl_hwcap_check. >>> >>> I've checked the build-log and see that the following files are compiled >>> with -march=zEC12: >>> - dl-printf.c >>> - ../sysdeps/unix/sysv/linux/dl-write.c >>> - dl-tunables.c >>> - ../sysdeps/unix/sysv/linux/dl-sysdep.c >>> - rtld.c >> >> Sorry, I missed that requirement. >> >> Would you mind testing the attached patch? >> >> Thanks, >> Florian > > Sure. Now it works fine and I get the expected: > Fatal glibc error: CPU lacks VXRS_EXT2 support (z15 or later required) Thanks. Should I push it with your Reviewed-by: and Tested-by:? Florian