From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6B5123858429 for ; Mon, 13 Dec 2021 11:17:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B5123858429 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-0-M2Vqw-Pnm2MFJZEZe1sQ-1; Mon, 13 Dec 2021 06:17:16 -0500 X-MC-Unique: 0-M2Vqw-Pnm2MFJZEZe1sQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9B5D624; Mon, 13 Dec 2021 11:17:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.17.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9432B5ED25; Mon, 13 Dec 2021 11:17:12 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: Rongwei Wang , libc-alpha@sourceware.org, hjl.tools@gmail.com, adhemerval.zanella@linaro.org, xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> <20211213110522.GT3294453@arm.com> Date: Mon, 13 Dec 2021 12:17:09 +0100 In-Reply-To: <20211213110522.GT3294453@arm.com> (Szabolcs Nagy's message of "Mon, 13 Dec 2021 11:05:22 +0000") Message-ID: <87sfuw21qi.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 11:17:21 -0000 * Szabolcs Nagy: > The 12/13/2021 10:51, Rongwei Wang via Libc-alpha wrote: >> When PT_LOAD segment alignment > the page size, allocate >> enough space to ensure that the segment can be properly >> aligned. >> >> And this change helps code segments use huge pages become >> simple and available. >> >> This fixes [BZ #28676]. >> >> Signed-off-by: Xu Yu >> Signed-off-by: Rongwei Wang > > > since this commit nptl/tst-stack4 consistently > fails in my 32bit arm test environment with > > pthread_create failed: 11 > pthread_create failed: 11 > pthread_create failed: 11 > pthread_create failed: 11 > pthread_create failed: 11 > pthread_create failed: 11 > pthread_create failed: 11 > tst-stack4: tst-stack4.c:69: dso_process: Assertion `handle[dso]' failed. > Didn't expect signal from child: got `Aborted' > > i suspect it simply runs out of memory. > > if this change pushes memory usage of the test > above 2G then i think either the test or the > patch have to be changed so 32bit targets can > still run it reliably. What are the p_align values of the involved objects? I would not expect any changes on 32-bit Arm because p_align and the run-time page size should match there. Thanks, Florian