From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, Stafford Horne <shorne@gmail.com>
Subject: Re: [PATCH v2] setjmp: Replace jmp_buf-macros.h with jmp_buf-macros.sym
Date: Fri, 19 Nov 2021 21:34:35 +0100 [thread overview]
Message-ID: <87sfvr995w.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211119195816.165835-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Fri, 19 Nov 2021 16:58:16 -0300")
* Adhemerval Zanella:
> It requires less boilerplate code for newer ports. The _Static_assert
> checks from internal setjmp are moved to its own internal test since
> setjmp.h is included early by multiple headers (to generate
> rtld-sizes.sym).
>
> The riscv jmp_buf-macros.h check is also redundant, it is already
> done by riscv configure.ac.
>
> Checked with a build for the affected architectures.
> ---
> Changes from v1:
> * Move __setjmp_check.c to internal test.
This version looks okay to me.
Thanks,
Florian
prev parent reply other threads:[~2021-11-19 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:58 Adhemerval Zanella
2021-11-19 20:34 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfvr995w.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).