From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C18C7385840D for ; Fri, 19 Nov 2021 20:34:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C18C7385840D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-1NcFSqbgPWGSAG84cj5hwA-1; Fri, 19 Nov 2021 15:34:39 -0500 X-MC-Unique: 1NcFSqbgPWGSAG84cj5hwA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72E58BAF80; Fri, 19 Nov 2021 20:34:38 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 657AF5D9DE; Fri, 19 Nov 2021 20:34:37 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Stafford Horne Subject: Re: [PATCH v2] setjmp: Replace jmp_buf-macros.h with jmp_buf-macros.sym References: <20211119195816.165835-1-adhemerval.zanella@linaro.org> Date: Fri, 19 Nov 2021 21:34:35 +0100 In-Reply-To: <20211119195816.165835-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Fri, 19 Nov 2021 16:58:16 -0300") Message-ID: <87sfvr995w.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 20:34:46 -0000 * Adhemerval Zanella: > It requires less boilerplate code for newer ports. The _Static_assert > checks from internal setjmp are moved to its own internal test since > setjmp.h is included early by multiple headers (to generate > rtld-sizes.sym). > > The riscv jmp_buf-macros.h check is also redundant, it is already > done by riscv configure.ac. > > Checked with a build for the affected architectures. > --- > Changes from v1: > * Move __setjmp_check.c to internal test. This version looks okay to me. Thanks, Florian