public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v5 1/8] Move malloc hooks into a compat DSO
Date: Tue, 06 Jul 2021 16:29:14 +0200	[thread overview]
Message-ID: <87sg0recsl.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <7f71ca86-3b98-7b26-a52f-0e191f015ee2@sourceware.org> (Siddhesh Poyarekar's message of "Tue, 6 Jul 2021 18:30:01 +0530")

* Siddhesh Poyarekar:

>> In general, it looks like it's time to add support for mtrace tests to
>> the setsuite (that is, tests-mtrace like tests-time64).
>
> ... or tests-mcheck/tests-malloc-check.  Would you be OK with having
> the test driver call mtrace() at all times?

Could we enable mtrace directly via LD_PRELOAD (or static linking),
without calling the function?

There's also the matter of not flagging potentially leaking allocations
from the test harness itself.

> I forgot to ask, would you like that to be part of this patchset or
> would you be OK with the testing enhancement coming in later?  Mtrace 
> already has some testing coverage through tst-mtrace for example and
> other tests using mtrace.

I don't have a strong preference.  Given the open questions, it's
probably best to delay the cleanup.

Thanks,
Florian


  parent reply	other threads:[~2021-07-06 14:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 17:08 [PATCH v5 0/8] malloc hooks removal Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 1/8] Move malloc hooks into a compat DSO Siddhesh Poyarekar
2021-07-06 10:17   ` Florian Weimer
2021-07-06 13:00     ` Siddhesh Poyarekar
2021-07-06 13:12       ` Siddhesh Poyarekar
2021-07-06 14:29       ` Florian Weimer [this message]
2021-07-06 14:40         ` Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 2/8] mcheck: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 3/8] Simplify __malloc_initialized Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 4/8] mtrace: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 5/8] glibc.malloc.check: " Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 6/8] Remove " Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 7/8] Remove __after_morecore_hook Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 8/8] Remove __morecore and __default_morecore Siddhesh Poyarekar
2021-07-06 19:45 ` [PATCH v5 0/8] malloc hooks removal DJ Delorie
2021-07-07  1:31   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg0recsl.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).