From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DAAAA385E83D for ; Tue, 6 Jul 2021 14:29:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DAAAA385E83D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-4OEH8LcXP0KhlnRNAOkBTQ-1; Tue, 06 Jul 2021 10:29:18 -0400 X-MC-Unique: 4OEH8LcXP0KhlnRNAOkBTQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF70C1B2C983; Tue, 6 Jul 2021 14:29:17 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E50E02EB1F; Tue, 6 Jul 2021 14:29:16 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v5 1/8] Move malloc hooks into a compat DSO References: <20210705170814.4132997-1-siddhesh@sourceware.org> <20210705170814.4132997-2-siddhesh@sourceware.org> <8735sriw5u.fsf@oldenburg.str.redhat.com> <7f71ca86-3b98-7b26-a52f-0e191f015ee2@sourceware.org> Date: Tue, 06 Jul 2021 16:29:14 +0200 In-Reply-To: <7f71ca86-3b98-7b26-a52f-0e191f015ee2@sourceware.org> (Siddhesh Poyarekar's message of "Tue, 6 Jul 2021 18:30:01 +0530") Message-ID: <87sg0recsl.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 14:29:23 -0000 * Siddhesh Poyarekar: >> In general, it looks like it's time to add support for mtrace tests to >> the setsuite (that is, tests-mtrace like tests-time64). > > ... or tests-mcheck/tests-malloc-check. Would you be OK with having > the test driver call mtrace() at all times? Could we enable mtrace directly via LD_PRELOAD (or static linking), without calling the function? There's also the matter of not flagging potentially leaking allocations from the test harness itself. > I forgot to ask, would you like that to be part of this patchset or > would you be OK with the testing enhancement coming in later? Mtrace > already has some testing coverage through tst-mtrace for example and > other tests using mtrace. I don't have a strong preference. Given the open questions, it's probably best to delay the cleanup. Thanks, Florian