From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 77B0F385801E for ; Fri, 25 Jun 2021 10:02:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77B0F385801E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-GY-ELfTeOteNWIDugh_vcg-1; Fri, 25 Jun 2021 06:02:03 -0400 X-MC-Unique: GY-ELfTeOteNWIDugh_vcg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE67F802C89; Fri, 25 Jun 2021 10:02:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AC4C5C1D1; Fri, 25 Jun 2021 10:02:01 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 21/34] Linux: Move mq_setattr from librt to libc References: <8e762ef150b8a2b00814ad60ef00ed2488e9b327.1623956057.git.fweimer@redhat.com> Date: Fri, 25 Jun 2021 12:02:00 +0200 In-Reply-To: (Adhemerval Zanella's message of "Thu, 24 Jun 2021 11:02:00 -0300") Message-ID: <87sg16dzzb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 10:02:09 -0000 * Adhemerval Zanella: >> +int >> +__mq_setattr (mqd_t mqdes, const struct mq_attr *__restrict mqstat, >> + struct mq_attr *__restrict omqstat) > > I think there is no need to use reserved identifiers here, so we can > use 'restrict' directly. It's meaningless anyway given the function body, so I have removed it. >> +{ >> + return INLINE_SYSCALL_CALL (mq_getsetattr, mqdes, mqstat, omqstat); >> +} Thanks, Flroian