From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A1C1F3947414 for ; Wed, 26 May 2021 17:16:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A1C1F3947414 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-XRsOULnvPlK1Kjisb2fcEw-1; Wed, 26 May 2021 13:16:40 -0400 X-MC-Unique: XRsOULnvPlK1Kjisb2fcEw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46F83A40C2; Wed, 26 May 2021 17:16:39 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 700101002EF0; Wed, 26 May 2021 17:16:38 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 02/11] nptl: Move createthread to pthread_create References: <20210526165728.1772546-1-adhemerval.zanella@linaro.org> <20210526165728.1772546-3-adhemerval.zanella@linaro.org> Date: Wed, 26 May 2021 19:16:36 +0200 In-Reply-To: <20210526165728.1772546-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 26 May 2021 13:57:19 -0300") Message-ID: <87sg29qutn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 17:16:44 -0000 * Adhemerval Zanella via Libc-alpha: > The 'create_thread' function is moved to pthread_create.c. It removes > the START_THREAD_DEFN and START_THREAD_SELF macros and make the > lock usage more clear (no need to cross-reference multiple files). > > No functional change. Please remove the remaining references to the macros nptl/pthread_create.c: unlocks PD->lock which synchronizes-with START_THREAD_DEFN in the nptl/pthread_create.c: createthread.c defines the macro START_THREAD_DEFN to the nptl/pthread_create.c: START_THREAD_SELF to the expression to optimally deliver the new and commit this separately. Thanks. Florian